> On June 9, 2017, 7:55 a.m., Alexander Kolbasov wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > > Line 3760 (original), 3764 (patched) > > <https://reviews.apache.org/r/59869/diff/7/?file=1746529#file1746529line3765> > > > > I am curious - how does the caller distinguish between the case when > > the empty list is returned because there are no new deltas and an empty > > list returned because we want to force a full snapshot?
This particular logic seems to exist in DBUpdateForwarder.java http://github.mtv.cloudera.com/CDH/sentry/blob/cdh5-1.5.1_ha/sentry-hdfs/sentry-hdfs-service/src/main/java/org/apache/sentry/hdfs/DBUpdateForwarder.java#L67-L71 - Vamsee ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59869/#review177446 ----------------------------------------------------------- On June 9, 2017, 11:22 p.m., Vamsee Yarlagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59869/ > ----------------------------------------------------------- > > (Updated June 9, 2017, 11:22 p.m.) > > > Review request for sentry, Alexander Kolbasov and Lei Xu. > > > Repository: sentry > > > Description > ------- > > * Changes on top of Lina's review (https://reviews.apache.org/r/59820/) > * Adds a couple of helper methods that would go under MSentryUtil > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/utils/SentryUtils.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryChange.java > 6011ef407aaf82d211c81f6d6a55975fb21261b9 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryUtil.java > 7558267546fc8c4dedc4f739df6092851becfc31 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 17856a4425be5c8971c51f7cfd9b2ef06001a2ab > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/model/TestMSentryUtil.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/59869/diff/9/ > > > Testing > ------- > > In progress. > > > Thanks, > > Vamsee Yarlagadda > >
