----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/#review184776 -----------------------------------------------------------
IMPORTANT: http://github.mtv.cloudera.com/CDH/sentry/blob/cdh5-1.5.1/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java#L307-L312 We should handle the case when the HDFSSync is also not enabled. Currently we only purge when the sync is present but ideally this should be done in both the cases. - Vamsee Yarlagadda On Sept. 7, 2017, 1:27 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62146/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 1:27 a.m.) > > > Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1929 > https://issues.apache.org/jira/browse/SENTRY-1929 > > > Repository: sentry > > > Description > ------- > > SENTRY-1929 When full HMS snapshot is created all higher notifications should > be purged > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6 > > > Diff: https://reviews.apache.org/r/62146/diff/1/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
