> On Sept. 7, 2017, 4:03 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > > Lines 402 (patched) > > <https://reviews.apache.org/r/62146/diff/3/?file=1817058#file1817058line402> > > > > I don't see CounterWait has the function reset(). did you forget to > > upload change of this file?
It is there if you click on CounterWait.java file. It is included in this review. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/#review184824 ----------------------------------------------------------- On Sept. 7, 2017, 8:06 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62146/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 8:06 a.m.) > > > Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1929 > https://issues.apache.org/jira/browse/SENTRY-1929 > > > Repository: sentry > > > Description > ------- > > SENTRY-1929 When full HMS snapshot is created all higher notifications should > be purged > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java > 9c9bb69e768a1e648bb16e8c7efaa6ca6edea797 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > d4feb380fa0f3bd5f237609a107295a2d23eae3b > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java > 93afb614d0916c60ca416f8904331e78dd1b85d2 > > > Diff: https://reviews.apache.org/r/62146/diff/3/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
