> On Sept. 7, 2017, 7:17 a.m., Vamsee Yarlagadda wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java > > Lines 138 (patched) > > <https://reviews.apache.org/r/62146/diff/2/?file=1817042#file1817042line138> > > > > What about pending waiters on the higher notification ID's?
The reason we are doing this is because waiters are now waitinng on smaller values. We can't wake up these waiters because this is a violation of the contract - the value is not reached yet. The use case for this is when our notifications got backwards which means that no HMS waiters should wait on old values. If they do, they'll eventually time out. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62146/#review184795 ----------------------------------------------------------- On Sept. 7, 2017, 7:06 a.m., Alexander Kolbasov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62146/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 7:06 a.m.) > > > Review request for sentry, Arjun Mishra, Brian Towles, Na Li, Sergio Pena, > Vamsee Yarlagadda, and Vadim Spector. > > > Bugs: SENTRY-1929 > https://issues.apache.org/jira/browse/SENTRY-1929 > > > Repository: sentry > > > Description > ------- > > SENTRY-1929 When full HMS snapshot is created all higher notifications should > be purged > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 1ef7dcc6e6615da8ddd3fae18f1026dc0a8505e6 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/CounterWait.java > 9c9bb69e768a1e648bb16e8c7efaa6ca6edea797 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java > d4feb380fa0f3bd5f237609a107295a2d23eae3b > > > Diff: https://reviews.apache.org/r/62146/diff/2/ > > > Testing > ------- > > > Thanks, > > Alexander Kolbasov > >
