-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64661/
-----------------------------------------------------------
(Updated Dec. 18, 2017, 4:36 p.m.)
Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar
kalvagadda, Na Li, Sergio Pena, and Vadim Spector.
Repository: sentry
Description
-------
When Solr is using Sentry server for authorization, it issues a lot of calls to
{{getGroupsByRoles()}} function in {{DelegateSentryStore}}.
This function isn't very efficient - it walks over each role in the set,
obtains role by name, get groups for each role, and collects all group names
into a set.
It may be possible to optimize it.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
4cb46abc5
Diff: https://reviews.apache.org/r/64661/diff/3/
Changes: https://reviews.apache.org/r/64661/diff/2-3/
Testing
-------
mvn -f sentry-provider/sentry-provider-db/pom.xml test
Thanks,
Arjun Mishra
