----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64661/#review194079 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java Line 252 (original), 254 (patched) <https://reviews.apache.org/r/64661/#comment272803> I recommend a better test for this method. It is tested in TestDelegateSentryStore.testGetGroupsByRoleNames(), which uses two roles with identical groups for each role. I'd define roles role1 and role2 with partially iverlapping groups for each, i.e. a couple of groups defined only for role1, another couple only for role2, and another couple for both role1 and role2. - Vadim Spector On Dec. 18, 2017, 4:36 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64661/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2017, 4:36 p.m.) > > > Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar > kalvagadda, Na Li, Sergio Pena, and Vadim Spector. > > > Repository: sentry > > > Description > ------- > > When Solr is using Sentry server for authorization, it issues a lot of calls > to {{getGroupsByRoles()}} function in {{DelegateSentryStore}}. > > This function isn't very efficient - it walks over each role in the set, > obtains role by name, get groups for each role, and collects all group names > into a set. > > It may be possible to optimize it. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > 4cb46abc5 > > > Diff: https://reviews.apache.org/r/64661/diff/3/ > > > Testing > ------- > > mvn -f sentry-provider/sentry-provider-db/pom.xml test > > > Thanks, > > Arjun Mishra > >
