-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64661/
-----------------------------------------------------------
(Updated Dec. 19, 2017, 8:04 p.m.)
Review request for sentry, Alexander Kolbasov, Brian Towles, kalyan kumar
kalvagadda, Na Li, Sergio Pena, and Vadim Spector.
Changes
-------
Taking into account Vadim, and Sasha's feedback
Repository: sentry
Description
-------
When Solr is using Sentry server for authorization, it issues a lot of calls to
{{getGroupsByRoles()}} function in {{DelegateSentryStore}}.
This function isn't very efficient - it walks over each role in the set,
obtains role by name, get groups for each role, and collects all group names
into a set.
It may be possible to optimize it.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java
4cb46abc5
sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java
69d16238f
Diff: https://reviews.apache.org/r/64661/diff/4/
Changes: https://reviews.apache.org/r/64661/diff/3-4/
Testing
-------
mvn -f sentry-provider/sentry-provider-db/pom.xml test
Thanks,
Arjun Mishra
