-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67006/#review202676
-----------------------------------------------------------




sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java
Line 27 (original), 29 (patched)
<https://reviews.apache.org/r/67006/#comment284636>

    I think we should have information about user here as well. We can use the 
TestSentryPermissions class to test user privileges.



sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java
Lines 143-151 (original), 143-151 (patched)
<https://reviews.apache.org/r/67006/#comment284637>

    What about having a TestUpdateableAuthzPermissions class to verify user 
privileges on this class?


- Sergio Pena


On May 8, 2018, 1:49 p.m., kalyan kumar kalvagadda wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67006/
> -----------------------------------------------------------
> 
> (Updated May 8, 2018, 1:49 p.m.)
> 
> 
> Review request for sentry, Na Li and Sergio Pena.
> 
> 
> Bugs: SENTRY-2173
>     https://issues.apache.org/jira/browse/SENTRY-2173
> 
> 
> Repository: sentry
> 
> 
> Description
> -------
> 
> PrivilegeInfo should be updated to hold the permissions added to the users.
> 
> PrivilegeInfo currently holds roles <=> privileges mapping. This data 
> structure should be made generic so that it could hold the permissions of 
> either roles/users on a given object.
> 
> 
> Diffs
> -----
> 
>   
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java
>  3b3a82e8fce7986bd046e96192105952aa6fa796 
>   
> sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java
>  2ad74403b279fc2feafda361c92bf6a3d259d0eb 
> 
> 
> Diff: https://reviews.apache.org/r/67006/diff/1/
> 
> 
> Testing
> -------
> 
> As there is not functional change. I juat made sure that all the existing 
> tests pass.
> 
> 
> Thanks,
> 
> kalyan kumar kalvagadda
> 
>

Reply via email to