> On May 8, 2018, 7:52 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > > Line 27 (original), 29 (patched) > > <https://reviews.apache.org/r/67006/diff/1/?file=2017908#file2017908line29> > > > > I think we should have information about user here as well. We can use > > the TestSentryPermissions class to test user privileges. > > Na Li wrote: > This update only updates data structure. the processing code will be in a > different jira. After that, we can test as you mentioned. > > Sergio Pena wrote: > Then should we change the jira name? The name suggests we are adding user > privileges 'Extend PrivilegeInfo to hold user privileges'
Sergio, as per the title i have extended PrivilegeInfo so that it can store user privileges. But i have added code to use it as part of thsi patch. > On May 8, 2018, 7:52 p.m., Sergio Pena wrote: > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java > > Lines 143-151 (original), 143-151 (patched) > > <https://reviews.apache.org/r/67006/diff/1/?file=2017909#file2017909line143> > > > > What about having a TestUpdateableAuthzPermissions class to verify user > > privileges on this class? This patch is just to change the datastructure. There is no functionality added. - kalyan kumar ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67006/#review202676 ----------------------------------------------------------- On May 8, 2018, 1:49 p.m., kalyan kumar kalvagadda wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67006/ > ----------------------------------------------------------- > > (Updated May 8, 2018, 1:49 p.m.) > > > Review request for sentry, Na Li and Sergio Pena. > > > Bugs: SENTRY-2173 > https://issues.apache.org/jira/browse/SENTRY-2173 > > > Repository: sentry > > > Description > ------- > > PrivilegeInfo should be updated to hold the permissions added to the users. > > PrivilegeInfo currently holds roles <=> privileges mapping. This data > structure should be made generic so that it could hold the permissions of > either roles/users on a given object. > > > Diffs > ----- > > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/SentryPermissions.java > 3b3a82e8fce7986bd046e96192105952aa6fa796 > > sentry-hdfs/sentry-hdfs-namenode-plugin/src/main/java/org/apache/sentry/hdfs/UpdateableAuthzPermissions.java > 2ad74403b279fc2feafda361c92bf6a3d259d0eb > > > Diff: https://reviews.apache.org/r/67006/diff/1/ > > > Testing > ------- > > As there is not functional change. I juat made sure that all the existing > tests pass. > > > Thanks, > > kalyan kumar kalvagadda > >
