----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69448/#review210874 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java Line 37 (original), 37 (patched) <https://reviews.apache.org/r/69448/#comment295676> should this be volatile or atomic? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java Line 145 (original), 149 (patched) <https://reviews.apache.org/r/69448/#comment295677> It is better to make initialized volatile - Na Li On Nov. 26, 2018, 7:36 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69448/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2018, 7:36 p.m.) > > > Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and > Sergio Pena. > > > Bugs: SENTRY-2464 > https://issues.apache.org/jira/browse/SENTRY-2464 > > > Repository: sentry > > > Description > ------- > > On starting UpdatableCache update thread, if blockUntilFirstReload value is > set to true, an exception thrownwill cause the cache to never initialize and > services using this cache will stop > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > 0dd7b4a61 > > > Diff: https://reviews.apache.org/r/69448/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
