----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69448/#review210902 -----------------------------------------------------------
Fix it, then Ship it! It looks good, just add to the warning message that the cache will be reloaded later in the next time interval or something. The reason is that if a user finds a warning messge, they expect an answer of what to do, right? sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java Lines 140 (patched) <https://reviews.apache.org/r/69448/#comment295718> If this is a warning, should the user expect to do something if tihs message appears on the log? If not, perhaps you should add to the message that the cache will be reloaded in the next refresh interval (in X seconds?). - Sergio Pena On Nov. 26, 2018, 7:36 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69448/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2018, 7:36 p.m.) > > > Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and > Sergio Pena. > > > Bugs: SENTRY-2464 > https://issues.apache.org/jira/browse/SENTRY-2464 > > > Repository: sentry > > > Description > ------- > > On starting UpdatableCache update thread, if blockUntilFirstReload value is > set to true, an exception thrownwill cause the cache to never initialize and > services using this cache will stop > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > 0dd7b4a61 > > > Diff: https://reviews.apache.org/r/69448/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
