> On Nov. 26, 2018, 7:44 p.m., Na Li wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > > Line 37 (original), 37 (patched) > > <https://reviews.apache.org/r/69448/diff/1/?file=2110388#file2110388line37> > > > > should this be volatile or atomic? > > Arjun Mishra wrote: > Lina, can you explain why adding volatile here is needed? For each Kafka > broker there is a single KafkaAuthzBinding instance. So > UpdatableCache#startUpdateThread will be called once by a KafkaBroker. This > means there will be a reloadData thread for each Kafka broker. > > Na Li wrote: > Is it possible for more than one threads to access that single > KafkaAuthzBinding instance? If so, we should define "initialized" as volatile > to handle concurrency correctly. Otherwise, you don't need to do so
It isn't since there is 1 KafkaAuthzBinding for every Kafka broker. Even if it was this change should be handled in a different ticket right? - Arjun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69448/#review210874 ----------------------------------------------------------- On Nov. 26, 2018, 7:36 p.m., Arjun Mishra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69448/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2018, 7:36 p.m.) > > > Review request for sentry, Haley Reeve, kalyan kumar kalvagadda, Na Li, and > Sergio Pena. > > > Bugs: SENTRY-2464 > https://issues.apache.org/jira/browse/SENTRY-2464 > > > Repository: sentry > > > Description > ------- > > On starting UpdatableCache update thread, if blockUntilFirstReload value is > set to true, an exception thrownwill cause the cache to never initialize and > services using this cache will stop > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/UpdatableCache.java > 0dd7b4a61 > > > Diff: https://reviews.apache.org/r/69448/diff/1/ > > > Testing > ------- > > > Thanks, > > Arjun Mishra > >
