----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14253/#review26312 -----------------------------------------------------------
sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java <https://reviews.apache.org/r/14253/#comment51405> Path shouldn't be hard coded. Path should be an input from the user. Also what if the path doesn't exist? sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java <https://reviews.apache.org/r/14253/#comment51403> We should make this configurable. We may want to start HS2 with a different super user say "hiveserver2" sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java <https://reviews.apache.org/r/14253/#comment51404> If kinit fails, we should raise an exception. Just raising a warning is insufficient because the setup has not happened correctly. We should also make keeping the policy file on HDFS configurable. We may want to run tests against an external HS2 and have the policy file on a localFS for a number of reasons. Again, we shouldn't be hard coding the keytab. sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java <https://reviews.apache.org/r/14253/#comment51406> What if this fails? We should raise an error. - Shreepadma Venugopalan On Sept. 21, 2013, 12:13 a.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14253/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2013, 12:13 a.m.) > > > Review request for sentry and Shreepadma Venugopalan. > > > Repository: sentry > > > Description > ------- > > When using UnmanagedHiveServer, we use hdfs on the cluster and hence policy > files need to be moved to hdfs > > > Diffs > ----- > > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java > fafe79b > > Diff: https://reviews.apache.org/r/14253/diff/ > > > Testing > ------- > > All tests pass. > > > Thanks, > > Sravya Tirukkovalur > >
