----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14253/#review26514 -----------------------------------------------------------
Ship it! LGTM! Some minor nits. sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java <https://reviews.apache.org/r/14253/#comment51732> nit: java style braces. sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java <https://reviews.apache.org/r/14253/#comment51733> nit:java style braces - Shreepadma Venugopalan On Sept. 27, 2013, 8:11 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14253/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2013, 8:11 p.m.) > > > Review request for sentry and Shreepadma Venugopalan. > > > Repository: sentry > > > Description > ------- > > When using UnmanagedHiveServer, we use hdfs on the cluster and hence policy > files need to be moved to hdfs > > > Diffs > ----- > > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java > fafe79b > > Diff: https://reviews.apache.org/r/14253/diff/ > > > Testing > ------- > > All tests pass. > > > Thanks, > > Sravya Tirukkovalur > >
