> On Sept. 21, 2013, 12:30 a.m., Shreepadma Venugopalan wrote: > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java, > > line 130 > > <https://reviews.apache.org/r/14253/diff/2/?file=355075#file355075line130> > > > > Path shouldn't be hard coded. Path should be an input from the user. > > Also what if the path doesn't exist?
Made this an input from user. > On Sept. 21, 2013, 12:30 a.m., Shreepadma Venugopalan wrote: > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java, > > line 132 > > <https://reviews.apache.org/r/14253/diff/2/?file=355075#file355075line132> > > > > We should make this configurable. We may want to start HS2 with a > > different super user say "hiveserver2" Made it configurable. > On Sept. 21, 2013, 12:30 a.m., Shreepadma Venugopalan wrote: > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java, > > line 140 > > <https://reviews.apache.org/r/14253/diff/2/?file=355075#file355075line140> > > > > If kinit fails, we should raise an exception. Just raising a warning is > > insufficient because the setup has not happened correctly. We should also > > make keeping the policy file on HDFS configurable. We may want to run tests > > against an external HS2 and have the policy file on a localFS for a number > > of reasons. > > Again, we shouldn't be hard coding the keytab. Made it configurable and added another variable "sentry.e2etest.policyOnHDFS". Raising an exception if kinit fails. > On Sept. 21, 2013, 12:30 a.m., Shreepadma Venugopalan wrote: > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java, > > line 147 > > <https://reviews.apache.org/r/14253/diff/2/?file=355075#file355075line147> > > > > What if this fails? We should raise an error. > > Remove might fail, if there is no file found at that location. Exception is thrown if the new policy file cannot be put on HDFS. - Sravya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14253/#review26312 ----------------------------------------------------------- On Sept. 27, 2013, 8:11 p.m., Sravya Tirukkovalur wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/14253/ > ----------------------------------------------------------- > > (Updated Sept. 27, 2013, 8:11 p.m.) > > > Review request for sentry and Shreepadma Venugopalan. > > > Repository: sentry > > > Description > ------- > > When using UnmanagedHiveServer, we use hdfs on the cluster and hence policy > files need to be moved to hdfs > > > Diffs > ----- > > > sentry-provider/sentry-provider-file/src/main/java/org/apache/sentry/provider/file/PolicyFile.java > fafe79b > > Diff: https://reviews.apache.org/r/14253/diff/ > > > Testing > ------- > > All tests pass. > > > Thanks, > > Sravya Tirukkovalur > >
