> On July 24, 2014, 1:16 a.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > line 463 > > <https://reviews.apache.org/r/23796/diff/1/?file=638905#file638905line463> > > > > why are we returning empty children if parent grantOption >=0 ?
According to your idea: if grantOption!=null, we will only remove that specific privilege, so there is no child. if grantOption==null, we will remove all privileges for grantOption == any value, so we will add those privileges to childs. > On July 24, 2014, 1:16 a.m., Sravya Tirukkovalur wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java, > > lines 486-490 > > <https://reviews.apache.org/r/23796/diff/1/?file=638905#file638905line486> > > > > Even not setting this filter should return all rows with other filters > > matched right? Yes, grantOption must not be null in database. I will remove this filter. - Xiaomeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23796/#review48597 ----------------------------------------------------------- On July 22, 2014, 7:40 a.m., Xiaomeng Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23796/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 7:40 a.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Now hive don't support revoke grant option. > But when revoke privilege, we also should check grant option. > And hive revoke privilege SQL has no "with grant option", it is a little > different from grant check. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > ff8acdc > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 7637376 > > Diff: https://reviews.apache.org/r/23796/diff/ > > > Testing > ------- > > The unit test is included in the patch. > > > Thanks, > > Xiaomeng Huang > >
