----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23796/ -----------------------------------------------------------
(Updated July 28, 2014, 8:09 a.m.) Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya Tirukkovalur. Changes ------- change data type of grantOption from int to Boolean, so update the patch. Repository: sentry Description ------- Now hive don't support revoke grant option. But when revoke privilege, we also should check grant option. And hive revoke privilege SQL has no "with grant option", it is a little different from grant check. Diffs (updated) ----- sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java ff8acdc sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java 7637376 Diff: https://reviews.apache.org/r/23796/diff/ Testing ------- The unit test is included in the patch. Thanks, Xiaomeng Huang
