> On July 24, 2014, 1:19 a.m., Sravya Tirukkovalur wrote: > > One way we could handle some components supporting with grant in revoke is: > > - If grantOption is null, then we basically remove all privileges for > > grantOption == any value > > - If grantOption is set with a value, then we basically only remove those > > specific privileges. > > And with that we can also go with a binary value for grantOption. > > > > Does that make sense?
It make sense. Thanks Sravya! - Xiaomeng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23796/#review48606 ----------------------------------------------------------- On July 22, 2014, 7:40 a.m., Xiaomeng Huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/23796/ > ----------------------------------------------------------- > > (Updated July 22, 2014, 7:40 a.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Now hive don't support revoke grant option. > But when revoke privilege, we also should check grant option. > And hive revoke privilege SQL has no "with grant option", it is a little > different from grant check. > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > ff8acdc > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 7637376 > > Diff: https://reviews.apache.org/r/23796/diff/ > > > Testing > ------- > > The unit test is included in the patch. > > > Thanks, > > Xiaomeng Huang > >
