----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25977/#review57467 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java <https://reviews.apache.org/r/25977/#comment98171> Nit: It would be better to define the common tags like namespace in a single place sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java <https://reviews.apache.org/r/25977/#comment98178> The test is registering 3 services and calling getServiceInstance() 4 times. - Prasad Mujumdar On Oct. 9, 2014, 5:45 a.m., Sun Dapeng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25977/ > ----------------------------------------------------------- > > (Updated Oct. 9, 2014, 5:45 a.m.) > > > Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and > Sravya Tirukkovalur. > > > Bugs: SENTRY-456 > https://issues.apache.org/jira/browse/SENTRY-456 > > > Repository: sentry > > > Description > ------- > > * Add curator dependence in pom.xml. > * HAContext is used for Store HAContext related configuration > * ServiceManager is used for get avaliable service from Zookeeper > * ServiceRegister is used for register current service to Zookeeper > > > Diffs > ----- > > pom.xml e172e92 > sentry-provider/sentry-provider-db/pom.xml b4167e4 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 52eaeed > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25977/diff/ > > > Testing > ------- > > * TestSentryServiceDiscovery.java is the Unit Test > * Other Unit Test passed in local environment > > > Thanks, > > Sun Dapeng > >
