> On 十月 21, 2014, 8:24 a.m., Prasad Mujumdar wrote: > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java, > > line 107 > > <https://reviews.apache.org/r/25977/diff/1/?file=703990#file703990line107> > > > > Nit: It would be better to define the common tags like namespace in a > > single place
Okay, good suggestion. > On 十月 21, 2014, 8:24 a.m., Prasad Mujumdar wrote: > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java, > > line 106 > > <https://reviews.apache.org/r/25977/diff/1/?file=703991#file703991line106> > > > > The test is registering 3 services and calling getServiceInstance() 4 > > times. Thank Prasad, I will change it, but it's okay actually, serviceInstance will always is service map. - Sun ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25977/#review57467 ----------------------------------------------------------- On 十月 27, 2014, 2:29 p.m., Sun Dapeng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25977/ > ----------------------------------------------------------- > > (Updated 十月 27, 2014, 2:29 p.m.) > > > Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and > Sravya Tirukkovalur. > > > Bugs: SENTRY-456 > https://issues.apache.org/jira/browse/SENTRY-456 > > > Repository: sentry > > > Description > ------- > > * Add curator dependence in pom.xml. > * HAContext is used for Store HAContext related configuration > * ServiceManager is used for get avaliable service from Zookeeper > * ServiceRegister is used for register current service to Zookeeper > > > Diffs > ----- > > pom.xml e172e92 > sentry-provider/sentry-provider-db/pom.xml b4167e4 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 52eaeed > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25977/diff/ > > > Testing > ------- > > * TestSentryServiceDiscovery.java is the Unit Test > * Other Unit Test passed in local environment > > > Thanks, > > Sun Dapeng > >
