----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25977/#review60748 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java <https://reviews.apache.org/r/25977/#comment102148> I Apologize for the late review.. But... this might not work with a Secure Zookeeper cluster.. You would need to provide an ACLProvider implementation and set it in the builder using the .aclProvider(..) method. For pointers on how to set the ACL provider, you might want to check out how its being used in some of the hadoop classes (Specifically ZKDelegationTokenSecretManager : https://github.com/apache/hadoop/blob/8a261e68e4177b47be01ceae7310ea56aeb7ca38/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/ZKDelegationTokenSecretManager.java) - Arun Suresh On Oct. 27, 2014, 6:29 a.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25977/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2014, 6:29 a.m.) > > > Review request for sentry, Arun Suresh, Lenni Kuff, Prasad Mujumdar, and > Sravya Tirukkovalur. > > > Bugs: SENTRY-456 > https://issues.apache.org/jira/browse/SENTRY-456 > > > Repository: sentry > > > Description > ------- > > * Add curator dependence in pom.xml. > * HAContext is used for Store HAContext related configuration > * ServiceManager is used for get avaliable service from Zookeeper > * ServiceRegister is used for register current service to Zookeeper > > > Diffs > ----- > > pom.xml e172e92 > sentry-provider/sentry-provider-db/pom.xml b4167e4 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/FixedJsonInstanceSerializer.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/HAContext.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceManager.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/ServiceRegister.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/ServiceConstants.java > 52eaeed > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryServiceDiscovery.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25977/diff/ > > > Testing > ------- > > * TestSentryServiceDiscovery.java is the Unit Test > * Other Unit Test passed in local environment > > > Thanks, > > Dapeng Sun > >
