----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28547/#review63376 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java <https://reviews.apache.org/r/28547/#comment105610> I thought about this more over the weekend, I think this behavior is a bit confusing. Consider the case where you have Table -> SELECT Column -> INSERT If you call "populateChildren" you will get back all the column privileges, with their action set to SELECT! If someone did not understand this very subtle behavior it would be easy for them to write buggy code that went through and removed all child privileges. I think the correct fix is to mix what you are doing here along with my change in SENTRY-543 it will handle the downgrade and also properly use implies. - Lenni Kuff On Dec. 1, 2014, 7:45 a.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28547/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2014, 7:45 a.m.) > > > Review request for sentry and Lenni Kuff. > > > Bugs: SENTRY-552 > https://issues.apache.org/jira/browse/SENTRY-552 > > > Repository: sentry > > > Description > ------- > > Updated the patch accroding Lenni's feedback > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 073bb33 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > e8be81f > > Diff: https://reviews.apache.org/r/28547/diff/ > > > Testing > ------- > > UnitTests in local > > > Thanks, > > Dapeng Sun > >
