----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28547/#review63495 -----------------------------------------------------------
Ship it! sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java <https://reviews.apache.org/r/28547/#comment105763> This might accidently include privileges that don't actualy imply the parent. It's probably safest to always call implies to perform the scope checks after setting the action: if (isActionAll(childPriv.getAction())) childPriv.setAction(...); if (!parent.implies(childPriv)) continue; sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java <https://reviews.apache.org/r/28547/#comment105762> Thanks for adding this. Should this be an instance method on MSentryPrivilege? - Lenni Kuff On Dec. 2, 2014, 5:09 a.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28547/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 5:09 a.m.) > > > Review request for sentry and Lenni Kuff. > > > Bugs: SENTRY-552 > https://issues.apache.org/jira/browse/SENTRY-552 > > > Repository: sentry > > > Description > ------- > > Updated the patch accroding Lenni's feedback > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 073bb33 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 5bb00f5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > 3189955 > > Diff: https://reviews.apache.org/r/28547/diff/ > > > Testing > ------- > > UnitTests in local > > > Thanks, > > Dapeng Sun > >
