----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28547/#review63498 -----------------------------------------------------------
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java <https://reviews.apache.org/r/28547/#comment105767> Just one suggestion about the annotation, we'd better change to "Only include the child privilege that be implied by the parent privilege." Notice that parent privilege implies child privilege, rather than child privilege implies parent privilege. - Xiaomeng Huang On 十二月 2, 2014, 7:32 a.m., Dapeng Sun wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28547/ > ----------------------------------------------------------- > > (Updated 十二月 2, 2014, 7:32 a.m.) > > > Review request for sentry and Lenni Kuff. > > > Bugs: SENTRY-552 > https://issues.apache.org/jira/browse/SENTRY-552 > > > Repository: sentry > > > Description > ------- > > Updated the patch accroding Lenni's feedback > > > Diffs > ----- > > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/model/MSentryPrivilege.java > ed081a3 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 073bb33 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestSentryStore.java > 5bb00f5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDatabaseProvider.java > 3189955 > > Diff: https://reviews.apache.org/r/28547/diff/ > > > Testing > ------- > > UnitTests in local > > > Thanks, > > Dapeng Sun > >
