----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25811/#review63610 -----------------------------------------------------------
sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BaseAction.java <https://reviews.apache.org/r/25811/#comment105889> If this a public class, maybe some comments to describe how this class is used... Else refactor into a private static inner class sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java <https://reviews.apache.org/r/25811/#comment105890> If this a public class, maybe some comments to describe how this class is used... Else refactor into a private static inner class sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java <https://reviews.apache.org/r/25811/#comment105892> can we give another name other than 'leftActions' ? sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java <https://reviews.apache.org/r/25811/#comment105891> If this a public class, maybe some comments to describe how this class is used... Else refactor into a private static inner class - Arun Suresh On Sept. 25, 2014, 6:29 a.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25811/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2014, 6:29 a.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Currently the sentryStore in Sentry only supports database structure > authorize model such as Hive/Impala, in order to support more components like > Solr or other no database authorization > model component. It needs to create a general store to communicate with > outside, the structure of privilege model should be hidden. The general store > uses interface to transfer the needed information of privilege > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java > 44b7b2b > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActionReader.java > PRE-CREATION > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BaseAction.java > PRE-CREATION > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchAction.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchActionReader.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizable.java > 4526c4e > > sentry-core/sentry-core-model-search/src/test/java/org/apache/sentry/core/search/TestSearchAction.java > PRE-CREATION > sentry-provider/sentry-provider-db/pom.xml b4167e4 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/persistent/GMPrivilegeSentryStore.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/persistent/SentryStoreBase.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/persistent/SentryStoreLayer.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/PrivilegeObject.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/genericModel/service/thrift/PrivilegeUtil.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/persistent/SentryStoreIntegrationBase.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/persistent/TestRoleAndGroupSentryStore.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/persistent/TestSearchPrivilegeSentryStore.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/genericModel/service/thrift/TestPrivilegeUtils.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25811/diff/ > > > Testing > ------- > > > Thanks, > > shen guoquan > >
