> On 十二月 2, 2014, 11:56 p.m., Arun Suresh wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BaseAction.java, > > line 19 > > <https://reviews.apache.org/r/25811/diff/2/?file=705112#file705112line19> > > > > If this a public class, maybe some comments to describe how this class > > is used... > > > > Else refactor into a private static inner class
Thanks for comments, i will fix it > On 十二月 2, 2014, 11:56 p.m., Arun Suresh wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java, > > line 23 > > <https://reviews.apache.org/r/25811/diff/2/?file=705113#file705113line23> > > > > If this a public class, maybe some comments to describe how this class > > is used... > > > > Else refactor into a private static inner class Thanks for comments, i will fix it > On 十二月 2, 2014, 11:56 p.m., Arun Suresh wrote: > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java, > > line 41 > > <https://reviews.apache.org/r/25811/diff/2/?file=705113#file705113line41> > > > > can we give another name other than 'leftActions' ? Thanks for comments, i will fix it > On 十二月 2, 2014, 11:56 p.m., Arun Suresh wrote: > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java, > > line 19 > > <https://reviews.apache.org/r/25811/diff/2/?file=705114#file705114line19> > > > > If this a public class, maybe some comments to describe how this class > > is used... > > > > Else refactor into a private static inner class Hi Arun. Thanks for your comment. I think you give me a good direction about refactor the patch. Moving all operations that involve just role or group to a separate class, the operations related the generic privileges to another class. I refactor this patch, let the operations that involve role or group parts to reuse the existing code, then write a new privilege operator to process the other requests. I have already update that pacth, please help me review it and feel free give your comments. Thanks a lot - shen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25811/#review63610 ----------------------------------------------------------- On 十二月 5, 2014, 2:40 p.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25811/ > ----------------------------------------------------------- > > (Updated 十二月 5, 2014, 2:40 p.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Currently the sentryStore in Sentry only supports database structure > authorize model such as Hive/Impala, in order to support more components like > Solr or other no database authorization > model component. It needs to create a general store to communicate with > outside, the structure of privilege model should be hidden. The general store > uses interface to transfer the needed information of privilege > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java > 44b7b2b > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActionReader.java > PRE-CREATION > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BasicAction.java > PRE-CREATION > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchAction.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchActionReader.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizable.java > 4526c4e > > sentry-core/sentry-core-model-search/src/test/java/org/apache/sentry/core/search/TestSearchAction.java > PRE-CREATION > sentry-provider/sentry-provider-db/pom.xml 3c9d318 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 7d2cb12 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25811/diff/ > > > Testing > ------- > > > Thanks, > > shen guoquan > >
