> On 十二月 15, 2014, 12:09 a.m., Arun Suresh wrote: > > Thanks for working on this Guoquan, > > > > The patch looks good overall.. > > > > My only comment probably is the whole ACTION framework (Compound and Basic > > action) > > I understand this is possibly the only way we can deal with this in the > > short run... But is it possible for you to look into maybe refactoring this > > into a BitField ? That way adding and removing ACTIONS will be easier and > > you might not need a Reader/Writier
hi Arun, thanks for your review. Using the bitField is a good idea, I have finish refactor the source code and update the patch soon. Thanks very much. - shen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25811/#review65064 ----------------------------------------------------------- On 十二月 5, 2014, 2:40 p.m., shen guoquan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25811/ > ----------------------------------------------------------- > > (Updated 十二月 5, 2014, 2:40 p.m.) > > > Review request for sentry, Arun Suresh, Prasad Mujumdar, and Sravya > Tirukkovalur. > > > Repository: sentry > > > Description > ------- > > Currently the sentryStore in Sentry only supports database structure > authorize model such as Hive/Impala, in order to support more components like > Solr or other no database authorization > model component. It needs to create a general store to communicate with > outside, the structure of privilege model should be hidden. The general store > uses interface to transfer the needed information of privilege > > > Diffs > ----- > > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/Action.java > 44b7b2b > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/ActionReader.java > PRE-CREATION > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/BasicAction.java > PRE-CREATION > > sentry-core/sentry-core-common/src/main/java/org/apache/sentry/core/common/CompoundAction.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/Field.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchAction.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchActionReader.java > PRE-CREATION > > sentry-core/sentry-core-model-search/src/main/java/org/apache/sentry/core/model/search/SearchModelAuthorizable.java > 4526c4e > > sentry-core/sentry-core-model-search/src/test/java/org/apache/sentry/core/search/TestSearchAction.java > PRE-CREATION > sentry-provider/sentry-provider-db/pom.xml 3c9d318 > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/DelegateSentryStore.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeObject.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/PrivilegeOperatePersistence.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreLayer.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/SentryStore.java > 7d2cb12 > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/SentryStoreIntegrationBase.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestDelegateSentryStore.java > PRE-CREATION > > sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/generic/service/persistent/TestPrivilegeOperatePersistence.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/25811/diff/ > > > Testing > ------- > > > Thanks, > > shen guoquan > >
