> On Feb. 5, 2015, 2:09 a.m., Xiaomeng Huang wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java, > > line 77 > > <https://reviews.apache.org/r/30605/diff/2/?file=849476#file849476line77> > > > > why not put prepareDBDataForTest to beforeClass?
good point, I'll update the patch. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30605/#review71129 ----------------------------------------------------------- On Feb. 5, 2015, 1:58 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30605/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 1:58 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Improve test cases in "TestPerDBConfiguration" > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java > 4452d9a > > Diff: https://reviews.apache.org/r/30605/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
