> On Feb. 6, 2015, 1:59 a.m., Xiaomeng Huang wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java, > > line 68 > > <https://reviews.apache.org/r/30605/diff/3/?file=850355#file850355line68> > > > > I think we just need to remove @Override and don't need to change name > > of this function.
If remove @Override only without change name, there will be an error like :"This instance method cannot override the static method from AbstractTestWithStaticConfiguration". > On Feb. 6, 2015, 1:59 a.m., Xiaomeng Huang wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java, > > line 556 > > <https://reviews.apache.org/r/30605/diff/3/?file=850353#file850353line556> > > > > count == 12? Could we refactor this function? e.g. make > > expectedCountRows(1) and expectedCount(12) be parameters of this function Thanks, this will be fixed. > On Feb. 6, 2015, 1:59 a.m., Xiaomeng Huang wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java, > > line 79 > > <https://reviews.apache.org/r/30605/diff/3/?file=850353#file850353line79> > > > > extra blank space Thanks, this will be fixed. > On Feb. 6, 2015, 1:59 a.m., Xiaomeng Huang wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java, > > line 396 > > <https://reviews.apache.org/r/30605/diff/3/?file=850353#file850353line396> > > > > why remove verifyCount here? Thanks, this will be fixed. - Colin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30605/#review71354 ----------------------------------------------------------- On Feb. 5, 2015, 7:13 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30605/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2015, 7:13 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Improve test cases in "TestPerDBConfiguration" > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > d08b4ee > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java > 4452d9a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java > 1ccab46 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > 9d15c95 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestAuthorizingObjectStore.java > 30041c5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetaStoreWithPigHCat.java > 13f9f33 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java > 90428cb > > Diff: https://reviews.apache.org/r/30605/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
