----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30605/#review71354 -----------------------------------------------------------
sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java <https://reviews.apache.org/r/30605/#comment117050> extra blank space sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java <https://reviews.apache.org/r/30605/#comment117046> why remove verifyCount here? sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java <https://reviews.apache.org/r/30605/#comment117049> count == 12? Could we refactor this function? e.g. make expectedCountRows(1) and expectedCount(12) be parameters of this function sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java <https://reviews.apache.org/r/30605/#comment117055> I think we just need to remove @Override and don't need to change name of this function. LGTM. I left a few comments and be feel to fix them. - Xiaomeng Huang On 二月 5, 2015, 7:13 a.m., Colin Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/30605/ > ----------------------------------------------------------- > > (Updated 二月 5, 2015, 7:13 a.m.) > > > Review request for sentry. > > > Repository: sentry > > > Description > ------- > > Improve test cases in "TestPerDBConfiguration" > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > d08b4ee > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPerDBConfiguration.java > 4452d9a > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestPrivilegesAtColumnScope.java > 1ccab46 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/AbstractMetastoreTestWithStaticConfiguration.java > 9d15c95 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestAuthorizingObjectStore.java > 30041c5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetaStoreWithPigHCat.java > 13f9f33 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestMetastoreEndToEnd.java > 90428cb > > Diff: https://reviews.apache.org/r/30605/diff/ > > > Testing > ------- > > > Thanks, > > Colin Ma > >
