> On Aug. 6, 2015, 4:46 a.m., Lenni Kuff wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbConnections.java, > > line 75 > > <https://reviews.apache.org/r/37155/diff/1/?file=1033077#file1033077line75> > > > > why comment out this verification? > > Anne Yu wrote: > Noticed if turn on setMetastoreListener on create and drop there will be > active clients still hanging on. I can file a seperate jira to track this > issue, but leave this test case uncomment with possible test faiures, put > jira into the comments.
sounds good, please do. > On Aug. 6, 2015, 4:46 a.m., Lenni Kuff wrote: > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java, > > line 560 > > <https://reviews.apache.org/r/37155/diff/1/?file=1033081#file1033081line560> > > > > Explain what verification this does. Do we want to just check if the > > actual contains expected or should we validate that they are equal? > > Anne Yu wrote: > Intend to check if all items in expected set could be found in returned > set; The reason is in case there is test data left from previous test cases. > But I can make it more accurate to check if all items in returned set are > also found in expected set, or returned set is equavilant to returned set. > Just whenever use this method ensure cleanup after method be called. i meant explain in the comment of the function. - Lenni ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37155/#review94350 ----------------------------------------------------------- On Aug. 6, 2015, 11:08 p.m., Anne Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37155/ > ----------------------------------------------------------- > > (Updated Aug. 6, 2015, 11:08 p.m.) > > > Review request for sentry and Lenni Kuff. > > > Bugs: SENTRY-834 > https://issues.apache.org/jira/browse/SENTRY-834 > > > Repository: sentry > > > Description > ------- > > Second effort to fix hive e2e test failures on a real cluster test: > TestDbConnections, TestDbExportImportPrivileges, TestDbJDBCInterface > > > Diffs > ----- > > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbConnections.java > 7024263 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbExportImportPrivileges.java > 3d67ab7 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbJDBCInterface.java > 27897f4 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/dbprovider/TestDbMetadataObjectRetrieval.java > 53c7d0b > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java > 16695f5 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestCrossDbOps.java > 5b1e2b8 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestExportImportPrivileges.java > b9e4da9 > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestJDBCInterface.java > 6a9ae5c > > sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/TestMetadataObjectRetrieval.java > fbfb031 > > Diff: https://reviews.apache.org/r/37155/diff/ > > > Testing > ------- > > https://builds.apache.org/job/PreCommit-SENTRY-Build/759/console > > > Thanks, > > Anne Yu > >
