seanyinx commented on a change in pull request #122: SCB-239 omega stateless
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r163430230
##########
File path:
alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/EventScanner.java
##########
@@ -92,11 +96,11 @@ private void updateCompensatedCommands() {
});
}
- private void deleteDuplicateSagaEndedEvents() {
+ private void deleteDuplicateEvents() {
try {
- eventRepository.deleteDuplicateEvents(SagaEndedEvent.name());
+
eventRepository.deleteDuplicateEvents(Arrays.asList(TxAbortedEvent.name(),
SagaEndedEvent.name()));
Review comment:
we don't delete duplicate events other than SagaEndedEvent. we need to keep
track of all events for troubleshooting and auditing purpose.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
