seanyinx commented on a change in pull request #122: SCB-239 omega stateless URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r165662755
########## File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/TxConsistentService.java ########## @@ -40,11 +51,33 @@ public boolean handle(TxEvent event) { return false; } + if (isEventWithTimeout(event)) { + saveTxTimeout(event); Review comment: I'd prefer scanning events and populate timeout table in scheduled task. if alpha fails right after this line, another alpha will save a duplicate timeout entry ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services