seanyinx commented on a change in pull request #122: SCB-239 omega stateless URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r163435128
########## File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/EventScanner.java ########## @@ -64,10 +66,12 @@ public void run() { private void pollEvents() { scheduler.scheduleWithFixedDelay( () -> { + abortTimeoutEvent(); saveUncompensatedEventsToCommands(); compensate(); updateCompensatedCommands(); - deleteDuplicateSagaEndedEvents(); + deleteDuplicateEvents(); Review comment: why not lock event row when scanning for timeout event to avoid duplicate aborted event? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services