http://codereview.appspot.com/224074/diff/5/1004 File java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java (right):
http://codereview.appspot.com/224074/diff/5/1004#newcode182 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java:182: println(formatHttpError(resp.getHttpStatusCode(), resp.getResponseAsString(), uri)); ServletOutputStream.println is limited to ascii while getResponseAsString return utf-8. So this line has the potential to cause an exception. Try to use write instead. http://codereview.appspot.com/224074/diff/5/1004#newcode184 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java:184: outputJs(uri, resp.getResponseAsString()); Why convert to string here, the original code in proxy handler used IOUtil to copy bytes for the regular case (faster) http://codereview.appspot.com/224074/diff/5/1004#newcode190 java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java:190: print(formatError(e, uri)); Same, use write instead of print Also maybe use formatHttpError (basically put error in html comment block) http://codereview.appspot.com/224074/show
