This one's weird. According to http://java.sun.com/javase/6/docs/technotes/guides/intl/encoding.doc.htmland other docs, UTF8 is the canonical string reference for java.lang ("UTF-8" for java.nio). Painful.
On Tue, Mar 2, 2010 at 10:11 PM, <[email protected]> wrote: > > http://codereview.appspot.com/224074/diff/5/1004 > File > > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java > (right): > > http://codereview.appspot.com/224074/diff/5/1004#newcode223 > > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java:223: > write(data.getBytes("UTF8")); > Shoudn't the charsetName passed to getBytes be "UTF-8" instead. > > http://codereview.appspot.com/224074/diff/5/1004#newcode237 > > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java:237: > write(uri.toString().getBytes("UTF8")); > Ditto > > http://codereview.appspot.com/224074/diff/5/1004#newcode239 > > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java:239: > write(StringEscapeUtils.escapeJavaScript(data).getBytes("UTF8")); > Ditto > > > http://codereview.appspot.com/224074/show >
