@write vs. println, where is it noted that println doesn't support anything but ASCII?
@UTF8, that's the idea here. I've added a comment. On Wed, Mar 3, 2010 at 9:50 AM, <[email protected]> wrote: > > http://codereview.appspot.com/224074/diff/5/1004 > File > > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java > (right): > > http://codereview.appspot.com/224074/diff/5/1004#newcode184 > > java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/ConcatProxyServlet.java:184: > outputJs(uri, resp.getResponseAsString()); > On 2010/03/03 17:02:05, zhoresh wrote: > >> Why convert to string here, the original code in proxy handler used >> > IOUtil to > >> copy bytes for the regular case (faster) >> > > Second thought I think I understand why - if the different resources has > different encoding, the conversion to string and back will make them all > utf-8. > Maybe just put a comment here that explain this. > > > http://codereview.appspot.com/224074/show >
