http://codereview.appspot.com/1811042/diff/6001/7001
File main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java
(right):

http://codereview.appspot.com/1811042/diff/6001/7001#newcode89
main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:89: // In
case of errors where we want to short circuit the rewriting and
Update this comment?

http://codereview.appspot.com/1811042/diff/6001/7001#newcode105
main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:105:
sendResponseToUser(req, results, response);
How about just sendResponse?

http://codereview.appspot.com/1811042/diff/6001/7001#newcode229
main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:229:
return new HttpResponseBuilder()
When can results be null? Earlier, we used to return SC_BAD_REQUEST, now
we return SC_NOT_FOUND - is this intentional?

http://codereview.appspot.com/1811042/show

Reply via email to