http://codereview.appspot.com/1811042/diff/6001/7001 File main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java (right):
http://codereview.appspot.com/1811042/diff/6001/7001#newcode89 main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:89: // In case of errors where we want to short circuit the rewriting and On 2010/07/13 14:09:44, anupama.dutta wrote:
Update this comment?
Done. http://codereview.appspot.com/1811042/diff/6001/7001#newcode105 main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:105: sendResponseToUser(req, results, response); On 2010/07/13 14:09:44, anupama.dutta wrote:
How about just sendResponse?
Done. http://codereview.appspot.com/1811042/diff/6001/7001#newcode229 main/java/org/apache/shindig/gadgets/servlet/AccelHandler.java:229: return new HttpResponseBuilder() On 2010/07/13 14:09:44, anupama.dutta wrote:
When can results be null? Earlier, we used to return SC_BAD_REQUEST,
now we
return SC_NOT_FOUND - is this intentional?
Ideally results should never be null. It might be null in case of some bug in caching mechanism if we add the key but say the request times out and we never remove it from the cache. But still in those cases as well, the request sent by user was probably well formed, so we should not throw a bad request. I think we should throw a 404 not found. What do you think ? http://codereview.appspot.com/1811042/show
