http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java (right):
http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java#newcode29 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java:29: import com.sun.imageio.plugins.jpeg.JPEGImageWriter; On 2010/10/11 06:09:49, anupama.dutta wrote:
Order imports?
These two imports are from different places, i guess order is correct. http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java#newcode81 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java:81: // This optimization reduces the images size by addition 4-6% without On 2010/10/11 06:09:49, anupama.dutta wrote:
Move this comment to shindig.properties.
Done. http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java (right): http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java#newcode54 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/OptimizerConfig.java:54: * Defaults On 2010/10/10 04:33:23, gagan.goku wrote:
would be nice if you mention that these are being used only for tests.
Done. http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/PNGOptimizer.java File java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/PNGOptimizer.java (left): http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/PNGOptimizer.java#oldcode92 java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/PNGOptimizer.java:92: ImageWriter writer = ImageIO.getImageWritersByFormatName("jpeg").next(); On 2010/10/11 06:09:49, anupama.dutta wrote:
A small note in the CL description indicating that this change (in PNGOptimizer.java) is a refactoring change, will be helpful.
Done. http://codereview.appspot.com/2322042/
