Re: Adding Huffmann Size Optimization to Jpeg Compression Params. (gives +(5-7)% of compression) (issue2322042)

[johnfargo]

great work; just one structuring comment.


http://codereview.appspot.com/2322042/diff/41001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java
(right):

http://codereview.appspot.com/2322042/diff/41001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java#newcode185
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java:185:
writeParam);
Could you use this same method call signature at line 190? If so, I'd
recommend doing:
ImageWriteParam metadataWriteParam = writeParam;
if (writer instanceof JPEGImageWriter) {
  // Comment about workaround
  metadataWriteParam = null;
}
writer.write(...);

http://codereview.appspot.com/2322042/