Some minor comments below. LGTM overall.

http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java
(right):

http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java#newcode29
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java:29:
import com.sun.imageio.plugins.jpeg.JPEGImageWriter;
Order imports?

http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java#newcode81
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/BaseOptimizer.java:81:
// This optimization reduces the images size by addition 4-6% without
Move this comment to shindig.properties.

http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/PNGOptimizer.java
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/PNGOptimizer.java
(left):

http://codereview.appspot.com/2322042/diff/30001/java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/PNGOptimizer.java#oldcode92
java/gadgets/src/main/java/org/apache/shindig/gadgets/rewrite/image/PNGOptimizer.java:92:
ImageWriter writer = ImageIO.getImageWritersByFormatName("jpeg").next();
A small note in the CL description indicating that this change (in
PNGOptimizer.java) is a refactoring change, will be helpful.

http://codereview.appspot.com/2322042/

Reply via email to