----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1533/#review1587 -----------------------------------------------------------
Ship it! Committed revision 1159925. Please close the JIRA and attach the patch to it. Also if you add JIRA to the bugs section of the review it will post all the updates to the JIRA, connecting the 2. - Ryan On 2011-08-20 17:31:02, Matthew Hatem wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1533/ > ----------------------------------------------------------- > > (Updated 2011-08-20 17:31:02) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > Fixes to actions feature to match spec (runAction and registerXHandler). > > JIRA posted: > https://issues.apache.org/jira/browse/SHINDIG-1575 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js > 1159890 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html > 1159890 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js > 1159890 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1159890 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml > 1159890 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js > 1159890 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js > 1159890 > > Diff: https://reviews.apache.org/r/1533/diff > > > Testing > ------- > > All JsUnit tests pass > > > Thanks, > > Matthew > >
