But at least we can fix the example code right? Matthew can file issue for Opensocial spec change just to fix the typo in the example to match the API name for 2.0.
Henry On Friday, August 19, 2011, Ryan J Baxter <[email protected]> wrote: > Henry we cant change the API name in the spec at this point. We will fix > them in the container in Next. Like you said we should create an issue > against the spec to track it. > > -Ryan > > Email: [email protected] > Phone: 978-899-3041 > developerWorks Profile > > > > From: Henry Saputra <[email protected]> > To: "[email protected]" <[email protected]>, > Cc: Ryan Baxter <[email protected]>, Matthew Hatem > <[email protected]> > Date: 08/19/2011 11:40 AM > Subject: Re: Review Request: Fixes to actions feature to match spec > (runAction and registerXHandler). > > > > Hi Matthew, > > Yes, please open defect and provide patch if you can to fix the example > code > in the spec. > > I think you are one of the champions for this feature right? I am not sure > if we could change the name of the API instead at this point. > Mark W is probably the best person to answer this. If we can't change the > spec to match the API names then the ref implementation in Shindig should > follow it till we change it in Next spec release. > > - Henry > > On Friday, August 19, 2011, Matthew Hatem <[email protected]> wrote: >> >> >>> On 2011-08-17 22:14:53, Ryan Baxter wrote: >>> > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js > , > line 251 >>> > < > https://reviews.apache.org/r/1533/diff/2/?file=32940#file32940line251> >>> > >>> > Same here the function is called registerHidActionsListener >>> >>> Matthew Hatem wrote: >>> The Core Gadget spec is wrong and inconsistent. The API should be > symmetric with the CommonContainer API which uses 'Handler' not > 'Listener'. >>> >>> Also, the examples in the Core Gadget spec uses 'Handler' >>> >>> var myShowActionsHandler = function(actionObjs){ >>> // draw the UI, toolbars menus, etc >>> // to do the invocation of the action, call the following > API: >>> // gadgets.actions.runAction(actionObjs[0].id); >>> } >>> gadgets.actions.registerShowActionsHandler(myShowActionHandler); >>> >>> Henry Saputra wrote: >>> So either we change the spec or change this code to match the spec. > Even though its maybe wrong but thats what in the final spec. >>> >>> I would prefer to have it wrong here to at least match the spec. > From > gadgets point of view I think its ok to be called xxxListener because it > listen actions event from container. >> >> I would prefer to change the spec but I understand if it's too late. >> >> I can change 'Handler' to 'Listener' now. >> >> Should I create a defect to update the example code in the spec. >> >> >> - Matthew >> >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> https://reviews.apache.org/r/1533/#review1512 >> ----------------------------------------------------------- >> >> >> On 2011-08-19 13:56:41, Matthew Hatem wrote: >>> >>> ----------------------------------------------------------- >>> This is an automatically generated e-mail. To reply, visit: >>> https://reviews.apache.org/r/1533/ >>> ----------------------------------------------------------- >>> >>> (Updated 2011-08-19 13:56:41) >>> >>> >>> Review request for shindig and Ryan Baxter. >>> >>> >>> Summary >>> ------- >>> >>> Fixes to actions feature to match spec (runAction and > registerXHandler). >>> >>> JIRA posted: >>> https://issues.apache.org/jira/browse/SHINDIG-1575 >>> >>> >>> Diffs >>> ----- >>> >>> > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js1157952 > >>> > http://svn.apache.org/repos/asf/shindig/trunk/ < http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html1157952 > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xmlPRE-CREATION > >>> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js1157952 > >>> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js1157952 > >>> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml1157952 > >>> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js1157952 > >>> > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js1157952 > >>> >>> Diff: https://reviews.apache.org/r/1533/diff >>> >>> >>> Testing >>> ------- >>> >>> All JsUnit tests pass >>> >>> >>> Thanks, >>> >>> Matthew >>> >>> >> >> > > > >
