----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1533/#review1584 -----------------------------------------------------------
Looks good, could you make sure content/samplecontainer/examples/conservcontainer/index.html is up to date and regenerate the patch? I am getting errors when applying it. - Ryan On 2011-08-19 13:56:41, Matthew Hatem wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/1533/ > ----------------------------------------------------------- > > (Updated 2011-08-19 13:56:41) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > Fixes to actions feature to match spec (runAction and registerXHandler). > > JIRA posted: > https://issues.apache.org/jira/browse/SHINDIG-1575 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/ConServContainer.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/index.html > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/content/samplecontainer/examples/conservcontainer/sample-actions-runner.xml > PRE-CREATION > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/actions_container.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/feature.xml > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/actions/taming.js > 1157952 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/test/javascript/features/actions/actions_test.js > 1157952 > > Diff: https://reviews.apache.org/r/1533/diff > > > Testing > ------- > > All JsUnit tests pass > > > Thanks, > > Matthew > >
