> On 2012-02-15 14:43:55, Dan Dumont wrote:
> > Could you please provide a bit more information on the use case that you
> > are trying and what's going on? I want to make sure I understand this
> > before I review.
> >
> > Also, there's a bunch of whitespace that needs to be cleaned up. Please
> > remove all trailing line whitespace =~/[ \t]+$//; (if you'll forgive my
> > perl)
> > Also, please use tab = 2 spaces + convert tabs to spaces.
>
> Yao Zhang wrote:
> Hi Dan, the story is:
> When you try to render a gadget to a certain dom node like this:
> var cc = new osapi.container.Container({});
> var site = cc.newGadgetSite(siteEle/*an existing dom node*/);
> cc.navigateGadget(site,....);
>
> Gadget rendering will fail if siteEle is a dom node is in side an iframe
> in top paranet window. The cause is rpc code is assuming the input dom node
> is just in the top parent window.
Hi Dan, I've updated the new patch that clean the spaces.
- Yao
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3908/#review5123
-----------------------------------------------------------
On 2012-03-01 06:29:05, Yao Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/3908/
> -----------------------------------------------------------
>
> (Updated 2012-03-01 06:29:05)
>
>
> Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton
> Sievers.
>
>
> Summary
> -------
>
> When you try to render a gadget to a dom node inside an existing iframe, rpc
> does not work as the code is using document.getElementById to get the domnode
>
>
> This addresses bug SHINDIG-1704.
> https://issues.apache.org/jira/browse/SHINDIG-1704
>
>
> Diffs
> -----
>
>
> http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js
> 1238149
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js
> 1291547
>
> Diff: https://reviews.apache.org/r/3908/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Yao
>
>
