> On March 1, 2012, 7:04 p.m., Henry Saputra wrote: > > I think the scenario is not what the rpc mechanism intend to do. The > > communication between container and gadgets happen between one parent > > window and a child window via iframe. > > Yao Zhang wrote: > Hi Henry, > There is the scenario that people want to render their gadget inside an > existing iframe(like inside a editor). And rcp prevent them do so... Do you > think this is a reasonable scenario?
Henry, in the past I've had conversations with Fargo about the flexibility of RPC and certain assumptions it makes around where elements live. He made it sound like the current RPC implementation *was* inflexible and really needed an overhaul. In lieu of a complete overhaul (maybe in the 3.0) timeframe, I think this patch gets us part of the way there and helps with a subset of use cases. - Stanton ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3908/#review5510 ----------------------------------------------------------- On March 19, 2012, 7:38 a.m., Yao Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3908/ > ----------------------------------------------------------- > > (Updated March 19, 2012, 7:38 a.m.) > > > Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton > Sievers. > > > Description > ------- > > When you try to render a gadget to a dom node inside an existing iframe, rpc > does not work as the code is using document.getElementById to get the domnode > > > This addresses bug SHINDIG-1704. > https://issues.apache.org/jira/browse/SHINDIG-1704 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js > 1299960 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site.gadget/gadget_holder.js > 1299960 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js > 1299960 > > Diff: https://reviews.apache.org/r/3908/diff/ > > > Testing > ------- > > > Thanks, > > Yao Zhang > >
