> On 2012-03-01 19:04:07, Henry Saputra wrote: > > I think the scenario is not what the rpc mechanism intend to do. The > > communication between container and gadgets happen between one parent > > window and a child window via iframe.
Hi Henry, There is the scenario that people want to render their gadget inside an existing iframe(like inside a editor). And rcp prevent them do so... Do you think this is a reasonable scenario? - Yao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/3908/#review5510 ----------------------------------------------------------- On 2012-03-01 06:29:05, Yao Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/3908/ > ----------------------------------------------------------- > > (Updated 2012-03-01 06:29:05) > > > Review request for shindig, Henry Saputra, li xu, Dan Dumont, and Stanton > Sievers. > > > Summary > ------- > > When you try to render a gadget to a dom node inside an existing iframe, rpc > does not work as the code is using document.getElementById to get the domnode > > > This addresses bug SHINDIG-1704. > https://issues.apache.org/jira/browse/SHINDIG-1704 > > > Diffs > ----- > > > http://svn.apache.org/repos/asf/shindig/trunk/extras/src/main/javascript/features-extras/org.openajax.hub-2.0.5/iframe.js > 1238149 > > http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/rpc/rpc.js > 1291547 > > Diff: https://reviews.apache.org/r/3908/diff > > > Testing > ------- > > > Thanks, > > Yao > >
