----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4976/#review7498 -----------------------------------------------------------
Henry here is my first pass. I think we should also add support to the sample EE container for display type of image, what do you think? trunk/content/samplecontainer/examples/embeddedexperiences/BlogViewer.xml <https://reviews.apache.org/r/4976/#comment16596> is there any reason why you are calling the associated context id source? trunk/content/samplecontainer/examples/embeddedexperiences/BlogViewer.xml <https://reviews.apache.org/r/4976/#comment16595> clean up white space trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js <https://reviews.apache.org/r/4976/#comment16598> Shouldn't you verify that the display type is link and not image? trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js <https://reviews.apache.org/r/4976/#comment16597> why would only targets of type gadget return a title? A URL EE could also have a display title right? trunk/features/src/main/javascript/features/embeddedexperiences/constant.js <https://reviews.apache.org/r/4976/#comment16599> what about the associated context fields? trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js <https://reviews.apache.org/r/4976/#comment16603> I would prefer we be consistent and use single quotes for strings trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js <https://reviews.apache.org/r/4976/#comment16600> why are we passing opt_containerContext for URL embedded experiences? trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js <https://reviews.apache.org/r/4976/#comment16604> The preferred experience now allows the service to suggest what experience, gadget or url, they want the container to show, we should probably honor that by default in this function, but provide a way for containers to override that functionality if they want. trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js <https://reviews.apache.org/r/4976/#comment16605> I think we need more definition around what this function should return. We will need to make sure we clarify this for the container spec as well. - Ryan On 2012-05-02 23:24:37, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4976/ > ----------------------------------------------------------- > > (Updated 2012-05-02 23:24:37) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > Add code to handle EE extension for OpenSocial 2.5.0 core gadget spec: > http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model > http://docs.opensocial.org/display/OSD/Core-Gadget+-+Embedded+Experiences > > I remove the unneeded model for EmbeddedExperience because ActivityEntry uses > ExtendableBean, which act like a Map, to store opensocial and its extension > so there is no need to explicitly map embed or preferredExperience with > physical class: > java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java > java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java > > > This addresses bug SHINDIG-1762. > https://issues.apache.org/jira/browse/SHINDIG-1762 > > > Diffs > ----- > > trunk/content/samplecontainer/examples/embeddedexperiences/BlogViewer.xml > PRE-CREATION > trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js > 1333227 > trunk/content/sampledata/canonicaldb.json 1333227 > trunk/features/src/main/javascript/features/embeddedexperiences/constant.js > 1333227 > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js > 1333227 > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js > 1333227 > > trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js > 1333227 > > trunk/features/src/test/javascript/features/embeddedexperiences/embedded_experiences_container_test.js > 1333227 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java > 1333227 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java > 1333227 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityEntryTest.java > 1333227 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json > 1333227 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json > 1333227 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java > 1333227 > > Diff: https://reviews.apache.org/r/4976/diff > > > Testing > ------- > > Updated the unit tests and modify EE sample gadget to test passing additional > context and respect preferredExperience display link text. > > > Thanks, > > Henry > >
