> On 2012-05-03 13:12:56, Ryan Baxter wrote: > > trunk/content/samplecontainer/examples/embeddedexperiences/BlogViewer.xml, > > line 47 > > <https://reviews.apache.org/r/4976/diff/2/?file=106081#file106081line47> > > > > clean up white space
Will do =) > On 2012-05-03 13:12:56, Ryan Baxter wrote: > > trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, > > line 169 > > <https://reviews.apache.org/r/4976/diff/2/?file=106082#file106082line169> > > > > Shouldn't you verify that the display type is link and not image? Yeah, you are right. Will add check for link type. > On 2012-05-03 13:12:56, Ryan Baxter wrote: > > trunk/content/samplecontainer/examples/embeddedexperiences/BlogViewer.xml, > > line 39 > > <https://reviews.apache.org/r/4976/diff/2/?file=106081#file106081line39> > > > > is there any reason why you are calling the associated context id > > source? Just checking if the id is passed. This is just initial gadget for testing if all params are passed correctly. I will keep adding updates to this sample gadget later on. > On 2012-05-03 13:12:56, Ryan Baxter wrote: > > trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js, > > line 177 > > <https://reviews.apache.org/r/4976/diff/2/?file=106082#file106082line177> > > > > why would only targets of type gadget return a title? A URL EE could > > also have a display title right? This is just helper function to get the link text to update the UI. The only intention is to just show how container code could leverage the preferredExperience data structure. Later I will add more code to the sample gadget to make it better. > On 2012-05-03 13:12:56, Ryan Baxter wrote: > > trunk/features/src/main/javascript/features/embeddedexperiences/constant.js, > > line 71 > > <https://reviews.apache.org/r/4976/diff/2/?file=106084#file106084line71> > > > > what about the associated context fields? Will add those. Originally I thought its still pending so I didnt add them > On 2012-05-03 13:12:56, Ryan Baxter wrote: > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js, > > line 53 > > <https://reviews.apache.org/r/4976/diff/2/?file=106085#file106085line53> > > > > I would prefer we be consistent and use single quotes for strings Yeah, will use ' than " > On 2012-05-03 13:12:56, Ryan Baxter wrote: > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js, > > line 133 > > <https://reviews.apache.org/r/4976/diff/2/?file=106085#file106085line133> > > > > why are we passing opt_containerContext for URL embedded experiences? No we shouldnt, it was my bad copy-paste coding effort =( > On 2012-05-03 13:12:56, Ryan Baxter wrote: > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js, > > line 170 > > <https://reviews.apache.org/r/4976/diff/2/?file=106085#file106085line170> > > > > The preferred experience now allows the service to suggest what > > experience, gadget or url, they want the container to show, we should > > probably honor that by default in this function, but provide a way for > > containers to override that functionality if they want. I am not following this one. Are you suggesting if preferredExperience is not set then Shindig should set some default values? The values for preferredExperience will be used mostly by container before calling the navigate function. Other than context I dont think the rest of preferredExperience values are useful when actually rendering the gadget. > On 2012-05-03 13:12:56, Ryan Baxter wrote: > > trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js, > > line 177 > > <https://reviews.apache.org/r/4976/diff/2/?file=106087#file106087line177> > > > > I think we need more definition around what this function should > > return. We will need to make sure we clarify this for the container spec > > as well. This is just helper function to let container to have additional context before we open the gadget. Not sure if we need to add it in the container spec for the view. - Henry ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4976/#review7498 ----------------------------------------------------------- On 2012-05-02 23:24:37, Henry Saputra wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4976/ > ----------------------------------------------------------- > > (Updated 2012-05-02 23:24:37) > > > Review request for shindig and Ryan Baxter. > > > Summary > ------- > > Add code to handle EE extension for OpenSocial 2.5.0 core gadget spec: > http://docs.opensocial.org/display/OSD/More+precision+for+EE+data+model > http://docs.opensocial.org/display/OSD/Core-Gadget+-+Embedded+Experiences > > I remove the unneeded model for EmbeddedExperience because ActivityEntry uses > ExtendableBean, which act like a Map, to store opensocial and its extension > so there is no need to explicitly map embed or preferredExperience with > physical class: > java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java > java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java > > > This addresses bug SHINDIG-1762. > https://issues.apache.org/jira/browse/SHINDIG-1762 > > > Diffs > ----- > > trunk/content/samplecontainer/examples/embeddedexperiences/BlogViewer.xml > PRE-CREATION > trunk/content/samplecontainer/examples/embeddedexperiences/EEContainer.js > 1333227 > trunk/content/sampledata/canonicaldb.json 1333227 > trunk/features/src/main/javascript/features/embeddedexperiences/constant.js > 1333227 > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_container.js > 1333227 > > trunk/features/src/main/javascript/features/embeddedexperiences/embedded_experiences_gadgets.js > 1333227 > > trunk/features/src/main/javascript/features/open-views.ee/open-views-ee-container.js > 1333227 > > trunk/features/src/test/javascript/features/embeddedexperiences/embedded_experiences_container_test.js > 1333227 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/core/model/EmbeddedExperienceImpl.java > 1333227 > > trunk/java/social-api/src/main/java/org/apache/shindig/social/opensocial/model/EmbeddedExperience.java > 1333227 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/RestfulJsonActivityEntryTest.java > 1333227 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonDelete.json > 1333227 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/dataservice/integration/fixtures/ActivityEntryJsonGroup.json > 1333227 > > trunk/java/social-api/src/test/java/org/apache/shindig/social/sample/spi/JsonDbOpensocialServiceTest.java > 1333227 > > Diff: https://reviews.apache.org/r/4976/diff > > > Testing > ------- > > Updated the unit tests and modify EE sample gadget to test passing additional > context and respect preferredExperience display link text. > > > Thanks, > > Henry > >
